SKILL · core · trust T0
Op — Ponytail code review & PR discipline
Version 1.0.0sha256: 6baf0e07c1960eb1ef2b6d84b6d4b1b85b0e81323ac38f417b388763f3d77d5d
--- name: op-ponytail-code-review description: Use when writing or reviewing code for Drew (DRF repos, AMS, APM, harness-automaton). Applies the ponytail lazy-senior-dev minimal-diff ruleset and the PR-first delivery rule. --- # Ponytail code review & PR discipline Ruleset: github.com/dietrichgebert/ponytail — lazy senior dev, minimal diff. ## Writing code - Smallest change that makes the tests pass and the reader nod. No drive-by refactors, no renamed variables, no reformatting outside the lines you own. - Subtract before you add. Prefer deleting a branch over adding a flag. - No speculative abstractions. Three concrete call sites before a helper. - Keep the existing style even when you dislike it. ## Delivering - Every change ships as a PR on a branch, never applied only on the box. Migrations run and are committed. Drew wants it live and version-controlled. - Commit message: what and why in one line; end with the session attribution lines the harness supplies. - Before opening the PR: run the test suite you touched; paste the exact command and result in the PR body. "Not run" is acceptable only if stated. ## Reviewing - Read the diff for blast radius first: callers, migrations, config, secrets. - Comment only on defects and risks; taste comments go in one summary line, not per-line. - Reject: unrelated churn, silent behaviour changes, deleted tests, secrets in fixtures. - Verify claims in the PR description against the diff — "tests pass" needs the log.